sadpandajoe commented on code in PR #35691:
URL: https://github.com/apache/superset/pull/35691#discussion_r2445790376
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/components/DatasetUsageTab/index.tsx:
##########
@@ -145,7 +148,21 @@ const DatasetUsageTab = ({
behavior: 'smooth',
});
}
- }, 100);
+ });
+ }
+ prevLoadingRef.current = loading;
+
+ // Cleanup: cancel animation frame if component unmounts
+ return () => {
+ if (frameId !== undefined) {
+ cancelAnimationFrame(frameId);
+ }
+ };
Review Comment:
@copilot Won't this introduce conditional cleanup returns, which is an
anti-pattern in React?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
