bito-code-review[bot] commented on PR #35752:
URL: https://github.com/apache/superset/pull/35752#issuecomment-3423364604
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant Chart as BigNumber Chart<br/>🔄 Updated | ●●○ Medium
participant Transform as TransformProps
participant Utils as BigNumber Utils<br/>🔄 Updated | ●●○ Medium
participant Formatter as getTimeFormatter<br/>🔄 Updated | ●●○ Medium
participant Core as @superset-ui/core
participant Registry as TimeFormatterRegistry
Note over Utils: Enhanced with granularity<br/>parameter support
Chart->>Transform: Request time formatting
Transform->>Utils: Call getDateFormatter(timeFormat, granularity)
Utils->>Formatter: getTimeFormatter(timeFormat, granularity)
Formatter->>Core: Create granularity-aware formatter
Core->>Registry: Get time range formatter
Registry-->>Core: Return formatter instance
Core-->>Utils: Return enhanced time formatter
Utils-->>Transform: Return formatted time function
Transform-->>Chart: Apply time formatting to display
```
Critical path: BigNumber Chart->TransformProps->BigNumber
Utils->getTimeFormatter->@superset-ui/core
> **Note:** The getDateFormatter function now passes granularity to
getTimeFormatter, enabling more precise time formatting in BigNumber charts.
This enhances time display accuracy by considering the data's time
granularity when formatting dates.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
