bito-code-review[bot] commented on PR #35753:
URL: https://github.com/apache/superset/pull/35753#issuecomment-3423383738
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant DEV as Developer
participant STORE as Redux Store
participant SQLAB as SqlLab Module<br/>🔄 Updated | ●●○ Medium
participant PRED as Predicate Function<br/>🔄 Updated | ●●○ Medium
participant LISTENER as Action Listener
participant EVENTS as Query Events
Note over SQLAB: Removed memoizeOne optimization<br/>Direct function calls
now
DEV->>STORE: Dispatch SQL Lab Action
STORE->>SQLAB: Trigger event listener setup
SQLAB->>PRED: Create predicate with active editor ID
PRED->>SQLAB: Call getActiveEditorImmutableId()
SQLAB-->>PRED: Return immutable ID
PRED-->>LISTENER: Return filtered predicate
LISTENER->>EVENTS: Route events to correct tab
EVENTS-->>DEV: Execute query callbacks
```
Critical path: Redux Store->SqlLab Module->Predicate
Function->Action Listener->Query Events
> **Note:** The change removes memoizeOne optimization from
getActiveEditorImmutableId calls in the predicate function. This simplifies the
code by making direct function calls instead of memoized lookups, potentially
affecting performance but improving code clarity in SQL Lab event routing.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
