bito-code-review[bot] commented on PR #35779:
URL: https://github.com/apache/superset/pull/35779#issuecomment-3430330390
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant API as ExploreFormDataRestApi<br/>🔄 Updated | ●●○ Medium
participant CMD as CreateFormDataCommand<br/>🔄 Updated | ●●○ Medium
participant SES as Flask Session
participant ACC as Access Control
participant CACHE as Cache Manager
participant KEY as Cache Key Utils<br/>🔄 Updated | ●●○ Medium
Note over CMD: Added _get_session_id()<br/>method for testability
API->>CMD: CreateFormDataCommand(params).run()
CMD->>CMD: _get_session_id()
CMD->>SES: session.get("_id")
SES-->>CMD: session_id
CMD->>ACC: check_access(datasource_id, chart_id, type)
ACC-->>CMD: access_granted
CMD->>KEY: cache_key(session_id, tab_id, datasource_id, chart_id, type)
KEY-->>CMD: contextual_key
CMD->>CACHE: explore_form_data_cache.get/set
CACHE-->>API: form_data_key
```
Critical path: ExploreFormDataRestApi->CreateFormDataCommand->Flask
Session->Cache Key Utils->Cache Manager
> **Note:** The CreateFormDataCommand refactored session ID retrieval into a
separate _get_session_id() method, replacing direct session.get() calls. This
improves testability by allowing subclasses to override session behavior while
maintaining the same upstream API and downstream cache operations.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
