sadpandajoe opened a new pull request, #35809: URL: https://github.com/apache/superset/pull/35809
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Fixes the unreadable feature comparison table in superset/db_engine_specs/README.md by restructuring it from a single 52-column × 58-row table into 7 focused tables organized by feature category. **TECHNICAL CHANGES** superset/db_engine_specs/lib.py - Added calculate_support_level() to compute Supported/Partial/Not supported status - Added format_markdown_table() helper for consistent formatting - Refactored generate_focused_table() with preserve_order parameter - Rewrote generate_feature_tables() to output 7 tables instead of 1 - Fixed limit_clause to use documented allow_limit_clause attribute (defaults to True) - Aligned Feature Overview calculations with detail tables superset/db_engine_specs/README.md - Added Quick Navigation table of contents - Replaced single table with 7 focused tables - Updated intro text to explain organization - Fixed heading hierarchy (h3 for tables under h2 Features) - All feature documentation preserved ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Before - Single massive table: 52 columns × 58 rows - Databases as columns → horizontal growth with each new connector - GitHub markdown renderer fails on tables with >15 columns - Table was completely unreadable on GitHub After - 7 focused tables with 4-15 columns each - Databases as rows → sustainable vertical scaling - Tables grouped by feature category: a. Feature Overview (8 cols) - Quick summary with Supported/Partial/Not supported b. Database Information (5 cols) - Module paths, limit methods c. SQL Capabilities (12 cols) - JOINs, CTEs, subqueries, etc. d. Time Grains – Common (9 cols) - SECOND through YEAR e. Time Grains – Extended (14 cols) - Sub-hour and week variants f. Core Platform & Metadata Features (15 cols) - Integration capabilities g. Operational & Advanced Features (5 cols) - User impersonation, cost estimation, SQL validation - All 65 databases fully documented in each table - Table of contents with anchor links for easy navigation - All tables render perfectly on GitHub ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Regenerate tables (verify auto-generation still works): python superset/db_engine_specs/lib.py 2. View on GitHub (the real test): - Navigate to the README on GitHub - Verify all 7 tables render correctly - Check that horizontal scrolling is minimal/none - Verify table of contents anchor links work 3. Verify data accuracy: - Spot-check specific database features (e.g., PostgreSQL should show limit_clause: True) - Verify Feature Overview status matches detail tables - Confirm all 65 databases appear in each table ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: Fixes #35692 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
