nelsondrew commented on code in PR #35817:
URL: https://github.com/apache/superset/pull/35817#discussion_r2454778373
##########
superset-frontend/src/dashboard/components/Header/index.jsx:
##########
@@ -713,7 +720,8 @@ const Header = () => {
buttonStyle="secondary"
onClick={() => {
toggleEditMode();
- boundActionCreators.clearDashboardHistory?.(); // Resets the
`past` as an empty array
+ boundActionCreators.clearDashboardHistory?.();
Review Comment:
nit but can we extract this inline function outside since inline functions
cause performance issues on re renders
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
