bito-code-review[bot] commented on code in PR #35825:
URL: https://github.com/apache/superset/pull/35825#discussion_r2459135773
##########
docs/docs/configuration/cache.mdx:
##########
@@ -34,13 +33,29 @@ FILTER_STATE_CACHE_CONFIG = {
}
```
+To configure the filter state cache using MinIO or other S3 compatible service:
+
+```python
+FILTER_STATE_CACHE_CONFIG = {
+ 'CACHE_TYPE': 'minio_cache.MinioCacheBackend'
+ 'CACHE_MINIO_ENDPOINT': 'localhost:9000'
+ 'CACHE_MINIO_ACCESS_KEY': 'minioadmin'
+ 'CACHE_MINIO_SECRET_KEY': 'minioadmin'
+ 'CACHE_MINIO_BUCKET': 'superset'
+ 'CACHE_MINIO_SECURE': False # Set to True for HTTPS,
+ 'CACHE_DEFAULT_TIMEOUT': 300
+ 'CACHE_KEY_PREFIX': 'superset_filter_cache'
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Syntax error in MinIO cache config example</b></div>
<div id="fix">
The Python dictionary in the MinIO cache configuration example is missing
commas after each key-value pair, which would cause a SyntaxError if copied
directly. This breaks the configuration setup for users trying to implement
MinIO caching. The fix adds the required commas to make the code syntactically
valid.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```suggestion
FILTER_STATE_CACHE_CONFIG = {
'CACHE_TYPE': 'minio_cache.MinioCacheBackend',
'CACHE_MINIO_ENDPOINT': 'localhost:9000',
'CACHE_MINIO_ACCESS_KEY': 'minioadmin',
'CACHE_MINIO_SECRET_KEY': 'minioadmin',
'CACHE_MINIO_BUCKET': 'superset',
'CACHE_MINIO_SECURE': False, # Set to True for HTTPS
'CACHE_DEFAULT_TIMEOUT': 300,
'CACHE_KEY_PREFIX': 'superset_filter_cache'
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35825#issuecomment-3441456334>#73c4df</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
