bito-code-review[bot] commented on PR #35828:
URL: https://github.com/apache/superset/pull/35828#issuecomment-3441925228
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant Client as REST Client
participant API as DashboardRestApi<br/>🔄 Updated | ●●○ Medium
participant Export as ExportDashboardsCommand
participant Encoder as URL Encoder (quote)<br/>🟩 Added | ●●● High
participant Flask as Flask send_file
Client->>API: GET /api/v1/dashboard/export
API->>Export: ExportDashboardsCommand.run()
Export-->>API: Yield dashboard files
API->>Encoder: quote(filename, safe=".")
Encoder-->>API: Return encoded filename
API->>Flask: send_file(buf, download_name)
Flask-->>Client: HTTP 200 + ZIP attachment
```
Critical path: REST
Client->DashboardRestApi->ExportDashboardsCommand->URL Encoder
(quote)->Flask send_file
> **Note:** Added URL encoding to dashboard export filename using
urllib.parse.quote() to properly handle special characters in HTTP
Content-Disposition headers. Upstream REST API endpoint remains unchanged;
downstream Flask send_file() now receives properly encoded filename.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
