bito-code-review[bot] commented on PR #35863:
URL: https://github.com/apache/superset/pull/35863#issuecomment-3453060294
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant UI as Control Panel UI
participant CFCtrl as ConditionalFormattingControl<br/>🔄 Updated | ●●○ Medium
participant MapState as mapStateToProps()<br/>🔄 Updated | ●●● High
participant Explore as Explore State
participant TableRend as TableRenderer<br/>🔄 Updated | ●●○ Medium
participant GetColor as getCellColor()<br/>🟩 Added | ●●● High
participant DOM as Rendered Table
UI->>CFCtrl: Configure conditional formatting
CFCtrl->>MapState: Trigger state mapping
MapState->>Explore: Extract metrics, columns, rows
Explore-->>MapState: Return grouped values
MapState->>TableRend: Pass cellColorFormatters via tableOptions
TableRend->>GetColor: Apply color to column headers
GetColor-->>TableRend: Return backgroundColor
TableRend->>GetColor: Apply color to row headers
TableRend->>GetColor: Apply color to data cells
GetColor-->>TableRend: Return backgroundColor
TableRend->>DOM: Render styled table
```
Critical path: Control Panel UI -> ConditionalFormattingControl ->
mapStateToProps() -> TableRenderer -> getCellColor() -> Rendered Table
> **Note:** The diff refactors conditional formatting by extracting color
logic into a reusable getCellColor() method and enhancing mapStateToProps() to
include groupby columns/rows alongside metrics. This ensures consistent color
formatting across all table cells (headers and data) based on conditional
formatting rules configured in the control panel.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
