bito-code-review[bot] commented on code in PR #35865:
URL: https://github.com/apache/superset/pull/35865#discussion_r2468166133
##########
docs/yarn.lock:
##########
@@ -13257,10 +13114,10 @@ swagger-client@^3.35.7:
ramda "^0.30.1"
ramda-adjunct "^5.1.0"
-swagger-ui-react@^5.29.5:
- version "5.29.5"
- resolved
"https://registry.yarnpkg.com/swagger-ui-react/-/swagger-ui-react-5.29.5.tgz#8c6eafebb75972c15a9f3e24627caec10cc32cbe";
- integrity
sha512-D0YbsDhi4F38HsY5p1DjzuNduU/fVQxtqm3v0o2dRTF5BbLJYRSgjMZ79jejG4q3nNw4kuouCKKiq5xqCLjWrQ==
+swagger-ui-react@^5.30.0:
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Security vulnerability in swagger-ui-react
dependency</b></div>
<div id="fix">
The update to swagger-ui-react from 5.29.5 to 5.30.0 introduces a security
vulnerability CVE-2024-53382 in the prismjs dependency chain (swagger-ui-react
-> react-syntax-highlighter -> refractor -> prismjs), which allows DOM
Clobbering and potential XSS attacks. This affects the API documentation viewer
in the docs site. To mitigate, add yarn resolutions in docs/package.json to
force prismjs to a secure version 1.30.0 or later.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
- },
- "packageManager":
"[email protected]+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610"
-}
+ },
+ "resolutions": {
+ "prismjs": "^1.30.0"
+ },
+ "packageManager":
"[email protected]+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610"
+}
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35865#issuecomment-3454916207>#3fd39b</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
