bito-code-review[bot] commented on PR #35867:
URL: https://github.com/apache/superset/pull/35867#issuecomment-3455795082
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant UI as UI Layer<br/>OptionWrapper
participant DndCol as DndColumnSelect<br/>🔄 Updated | ●●○ Medium
participant OptionSel as OptionSelector<br/>🔄 Updated | ●●● High
participant State as Component State
participant Parent as Parent Component
Note over UI, Parent: Drag-drop reorder flow with validation
UI->>DndCol: onShiftOptions(dragIdx, hoverIdx)
DndCol->>OptionSel: reorder(dragIdx, hoverIdx)
OptionSel->>State: Update values array
State-->>DndCol: Updated array
DndCol->>Parent: onChange(newValues)
Parent-->>UI: Reflect reordered state
```
Critical path: UI Layer->DndColumnSelect->OptionSelector->Component
State->Parent Component
> **Note:** The diff refactors drag-drop reordering across multiple
components by replacing simple swap operations with splice-based reordering and
adding boundary validation. This prevents index out-of-bounds errors and
improves array manipulation reliability. Upstream callers (OptionWrapper, UI
handlers) remain stable; downstream state updates and parent notifications are
enhanced.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
