bito-code-review[bot] commented on PR #35872:
URL: https://github.com/apache/superset/pull/35872#issuecomment-3457722963
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant Config as Backend Config<br/>🔄 Updated | ●●● High
participant Theme as supersetTheme
participant GlobalStyles as GlobalStyles.tsx<br/>🟩 Added | ●●○ Medium
participant Markdown as Markdown Component
participant SafeMarkdown as SafeMarkdown
participant Test as Markdown.test.tsx<br/>🔄 Updated | ●●● High
Config->>Theme: fontWeightStrong: 600
Theme->>GlobalStyles: Apply font-weight to strong tags
GlobalStyles->>Markdown: CSS: strong { font-weight: 600; }
Markdown->>SafeMarkdown: Render markdown with **bold**
SafeMarkdown-->>Markdown: Render <strong> with 600 weight
Test->>Theme: Verify fontWeightStrong >= 600
Theme-->>Test: Assertion passes
```
Critical path: Backend
Config->supersetTheme->GlobalStyles.tsx->Markdown
Component->SafeMarkdown; Test validates theme value >= 600
> **Note:** The test assertion was tightened to require fontWeightStrong
>= 600 (semibold) instead of > 400, with clarified rationale that lower
values lack visual distinction. This drives a configuration update where the
backend fontWeightStrong must be increased from 500 to 600 to ensure bold
markdown text renders with adequate visual contrast.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
