bito-code-review[bot] commented on PR #35876:
URL: https://github.com/apache/superset/pull/35876#issuecomment-3458653429
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram">Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant UI as UI/User
participant Panel as ControlPanel<br/>🔄 Updated | ●●○ Medium
participant Plugin as ChartPlugin<br/>🔄 Updated | ●●○ Medium
participant FormData as EchartsWaterfallFormData<br/>🔄 Updated | ●●○ Medium
participant Transform as transformProps<br/>🔄 Updated | ●●● High
participant Transformer as transformer Function<br/>🔄 Updated | ●●● High
participant Chart as EchartsWaterfall
participant Echart as Echart Component
Note over Panel: New show_total checkbox<br/>control added with default true
UI->>Panel: Configure show_total setting
Panel->>Plugin: Pass formData with showTotal
Plugin->>Transform: Invoke transformProps
Transform->>FormData: Extract showTotal from formData
Transform->>Transformer: Call transformer with showTotal flag
Transformer->>Transformer: Conditionally push total records
Transformer-->>Transform: Return filtered transformedData
Transform-->>Chart: Return echartOptions with data
Chart->>Echart: Render chart
Echart-->>UI: Display waterfall chart
```
Critical path: UI -> ControlPanel -> ChartPlugin -> transformProps
-> transformer Function -> EchartsWaterfall -> Echart Component
> **Note:** Added showTotal control to conditionally display/hide cumulative
totals in waterfall charts. The control flows from UI through ControlPanel to
transformProps, where the transformer function conditionally includes total
records based on the showTotal flag.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]