bito-code-review[bot] commented on PR #35885:
URL: https://github.com/apache/superset/pull/35885#issuecomment-3461309472
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant ChartPlugin as ChartPlugin<br/>🔄 Updated | ●●○ Medium
participant TableChart as TableChart Component
participant CellRenderer as Cell Renderer
participant ColorFunc as cellBackground()
participant Theme as Theme Object
Note over ColorFunc: Changed color logic<br/>colorFillSecondary→colorFill
ChartPlugin->>TableChart: Load chart with data
TableChart->>CellRenderer: Render table cells
CellRenderer->>ColorFunc: Get cell background color
ColorFunc->>Theme: Query colorFill token
Theme-->>ColorFunc: Return color value
ColorFunc-->>CellRenderer: Apply background style
CellRenderer-->>TableChart: Render styled cell bar
```
Critical path: ChartPlugin->TableChart Component->Cell
Renderer->cellBackground()->Theme Object
> **Note:** The cellBackground function now uses theme.colorFill (solid)
instead of theme.colorFillSecondary with 50% transparency when
colorPositiveNegative is false. This change affects cell bar styling in table
visualizations, making them more visually prominent and consistent with the
primary theme color scheme.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
