Copilot commented on code in PR #35897:
URL: https://github.com/apache/superset/pull/35897#discussion_r2478950217
##########
superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.test.tsx:
##########
@@ -148,7 +149,7 @@ test('displays the correct input fields based on the
selected string type operat
expect(await screen.findByLabelText('Target value')).toBeInTheDocument();
});
-test('displays the toAllRow and toTextColor flags based on the selected
numeric type operator', () => {
+test('displays the toAllRow, toTextColor and toCellBar flags based on the
selected numeric type operator', () => {
Review Comment:
Extra space in 'toTextColor and'. Should be 'toTextColor and'.
```suggestion
test('displays the toAllRow, toTextColor and toCellBar flags based on the
selected numeric type operator', () => {
```
##########
superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.test.tsx:
##########
@@ -172,13 +174,15 @@ test('displays the toAllRow and toTextColor flags based
on the selected string t
expect(screen.getByText('To entire row')).toBeInTheDocument();
expect(screen.getByText('To text color')).toBeInTheDocument();
+ expect(screen.queryByText('To cell bar')).not.toBeInTheDocument();
});
-test('Not displays the toAllRow and toTextColor flags', () => {
+test('Not displays the toAllRow, toTextColor and toCellBar flags', () => {
Review Comment:
Grammatically incorrect test name. Should be 'Does not display' instead of
'Not displays'. Also has extra spaces before 'and' and after 'toCellBar'.
```suggestion
test('Does not display the toAllRow, toTextColor and toCellBar flags', () =>
{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
