Vitor-Avila commented on PR #35896: URL: https://github.com/apache/superset/pull/35896#issuecomment-3471376260
> Looks like you are adding Pillow to the base Docker image. I'm fine with that, and once this PR is in a major release I'll update https://superset.apache.org/docs/installation/docker-builds/ to remove Pillow as an add-on. > > But are Playwright and Chrome still not installed in the `python-common` or `lean` layers by default? If that's still the case, then does it help to add Pillow here? I think of Pillow as being needed for Alerts & Reports but if someone has to install Playwright and Chrome anyway would they install it then? Just wondering, and maybe I'm off-base here. Oh, you're right. I actually included it there just because in [this example](https://superset.apache.org/docs/installation/docker-builds/#building-your-own-production-docker-image) we have: ``` ... RUN . /app/.venv/bin/activate && \ uv pip install \ # install psycopg2 for using PostgreSQL metadata store - could be a MySQL package if using that backend: psycopg2-binary \ # add the driver(s) for your data warehouse(s), in this example we're showing for Microsoft SQL Server: pymssql \ # package needed for using single-sign on authentication: Authlib \ # openpyxl to be able to upload Excel files openpyxl \ # Pillow for Alerts & Reports to generate PDFs of dashboards Pillow \ # install Playwright for taking screenshots for Alerts & Reports. This assumes the feature flag PLAYWRIGHT_REPORTS_AND_THUMBNAILS is enabled # That feature flag will default to True starting in 6.0.0 # Playwright works only with Chrome. # If you are still using Selenium instead of Playwright, you would instead install here the selenium package and a headless browser & webdriver playwright \ && playwright install-deps \ && PLAYWRIGHT_BROWSERS_PATH=/usr/local/share/playwright-browsers playwright install chromium ... ``` I saw there _"Pillow for Alerts & Reports to generate PDFs of dashboards"_ and thought it was also needed for PDF reports which we want to use Playwright as well. Let me remove that part -- thanks for catching it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
