sadpandajoe opened a new pull request, #35969: URL: https://github.com/apache/superset/pull/35969
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Fixes a regression where the "View Query" modal displays a blank panel instead of helpful error messages when chart queries fail due to validation errors (e.g., missing required fields, invalid metrics). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> #### Automated Tests ```bash # Backend unit tests pytest tests/unit_tests/charts/commands/data/test_get_data_command.py -v # Frontend component test npm run test -- ViewQueryModal.test.tsx ``` #### Manual Testing **Test Case 1: Validation Error (The Fix)** 1. Create a chart in Explore view 2. Add duplicate metric labels (e.g., add "sum__num" twice) 3. Click "View Query" button 4. **Expected**: Red Alert shows "Duplicate column/metric labels: sum__num" 5. **Before fix**: Blank panel or generic error **Test Case 2: Valid Chart (No Regression)** 1. Create a valid chart 2. Click "View Query" 3. **Expected**: SQL query displayed normally 4. **Verify**: No regression on happy path **Test Case 3: Database Error (No Regression)** 1. Create a chart with invalid column in database 2. Click "View Query" 3. **Expected**: Shows SQL query (generated before execution error) 4. **Verify**: Database errors still work ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: Fixes #35492 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
