sadpandajoe opened a new pull request, #35993: URL: https://github.com/apache/superset/pull/35993
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Fixes flaky test failures and "Can't perform state update on unmounted component" warnings in `DatasourceControl.test.tsx` by addressing async race conditions, missing API mocks, and improper test cleanup. **Root causes fixed:** 1. **Unawaited userEvent calls** - 30+ `userEvent` interactions were not awaited, causing tests to end while React was still processing state updates 2. **Missing database API mock** - `DatasourceEditor` fetches `/api/v1/database/?q=*` on mount but the endpoint wasn't mocked, leaving background requests dangling 3. **Incomplete test cleanup** - Module-level spy and global mutations (window.location) were never cleaned up between tests 4. **Custom type drift** - Bespoke `TestDataset` type duplicated dataset shape, risking drift from the canonical `DatasetObject` 5. **Spy lifecycle bug** - Using `jest.restoreAllMocks()` killed the module-level spy after the first test, causing subsequent tests to potentially make real HTTP calls **Related work:** - Follow up to https://github.com/apache/superset/pull/35810 to `fix-datasource-editor-async` branch which fixes the `DatasourceEditor` component tests - This PR fixes `DatasourceControl` component tests - No conflicts between branches (different test files) ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
