khtruong opened a new issue #7768: TableSelector handle error tests do not run correctly URL: https://github.com/apache/incubator-superset/issues/7768 There are a few tests in spec/javascripts/components/TableSelector_spec.jsx that do not properly test promises: "fetchSchemas.should dispatch a danger toast on error" and "fetchTables.should dispatch a danger toast on error". These tests are not returning a promise and Jest just calls the promise and continues onto the next test. This causes false positives. The fix is to return the promise in the test. But when the tests are updated to return a promise, there are more errors. This issues tracks fixing up these unit tests. ### Expected results Verifies the promise logic correctly. ### Actual results Tests call the promise and move on to the next test, giving a false positive. #### How to reproduce the bug 1. Set breakpoints and "npm run test". 2. You will see that we are actually failing but the tests are green. ### Environment latest master
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
