LevisNgigi opened a new pull request, #35998:
URL: https://github.com/apache/superset/pull/35998

   <!---
   fix cross filter persisting after removal leaving charts in inconsistent 
state.
   -->
   
   ### SUMMARY
   When a cross-filter is applied, charts automatically reload to get this 
filter selection. If the cross-filter option is removed while charts are still 
loading, some of them would still load with the filtered option. Now when you 
apply cross-filter → Query A starts (with filter)
   Remove cross-filter → Query A is aborted → Query B starts (without filter)
   Only Query B completes
   Charts consistently show correct unfiltered data.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   BEFORE: 
   
   
https://github.com/user-attachments/assets/c1fd747c-4406-480f-996d-89007d026823
   
   
   AFTER:
   
   
   
https://github.com/user-attachments/assets/b953a7b0-8a63-42af-969f-9061316b456f
   
   
   ### TESTING INSTRUCTIONS
   1) Create a dashboard with several charts powered by the same dataset (so 
that cross filtering is possible).
   2) Apply a cross-filter value.
   3) Remove it from the native filter bar before all charts load.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to