Antonio-RiveroMartnez opened a new pull request, #36001:
URL: https://github.com/apache/superset/pull/36001

   ### SUMMARY
   We cannot tell which responses were coming form cache or not for the 
`ChartDataRestApi.data` entries in our event_logger.
   This PR extends the current `log_this_with_context` in event_logger so we 
can pass extra payload to it. With this new capability, we can include things 
like `is_cached` on entries for the `ChartDataRestApi.data` action
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Now the json for each entry for the `ChartDataRestApi.data` actions will 
have a new `is_cached` property we can use to tell apart which query result is 
coming form cache and which don't. It can be a single value or an array 
depending on how many queries the response had.
   
   <img width="916" height="934" alt="Screen Shot 2025-11-05 at 13 27 58 PM" 
src="https://github.com/user-attachments/assets/11a6a3f4-be24-49cb-b030-579d042b3423";
 />
   
   
   
   ### TESTING INSTRUCTIONS
   1. Access any chart in your app
   2. Run some queries on that chart
   3. Verify your entries in `logs` table and check you see a new `is_cached` 
value for the `ChartDataRestApi.data` actions
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [X] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to