EnxDev commented on code in PR #35888:
URL: https://github.com/apache/superset/pull/35888#discussion_r2494681850
##########
superset-frontend/src/explore/components/SaveModal.tsx:
##########
@@ -169,9 +169,8 @@ class SaveModal extends Component<SaveModalProps,
SaveModalState> {
handleRedirect = (windowLocationSearch: string, chart: any) => {
const searchParams = new URLSearchParams(windowLocationSearch);
searchParams.set('save_action', this.state.action);
- if (this.state.action !== 'overwrite') {
- searchParams.delete('form_data_key');
- }
+
+ searchParams.delete('form_data_key');
Review Comment:
> Just double-checking. If we now remove this always, is there any intended
functionality that we are going to lose?
Good question!
Previously, the cached ` form_data_key` could sometimes reference an
outdated datasource, causing charts to show stale data after saving changes.
By always removing it, we make sure the chart reloads from the database and
reflects the most up-to-date state.
The only minor trade-off is a slightly slower load, but it ensures full data
consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
