gabotorresruiz commented on code in PR #35871:
URL: https://github.com/apache/superset/pull/35871#discussion_r2499832723
##########
superset/commands/report/alert.py:
##########
@@ -212,8 +212,22 @@ def validate(self) -> None:
self._result = None
return
if df.empty and self._is_validator_operator:
- self._result = 0.0
- return
+ logger.error(
+ "Alert query returned empty result for report_schedule_id=%s, "
+ "execution_id=%s. This may indicate a query error or no data "
+ "matching the WHERE conditions. Query: %s",
+ self._report_schedule.id,
+ self._execution_id,
+ self._report_schedule.sql[:500],
+ )
+ raise AlertQueryError(
Review Comment:
Yes, we can. Not sure how the whole thing will behave. I can make a little
research just to see if we're safe to return NULL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
