betodealmeida opened a new pull request #7772: Reuse SVG node URL: https://github.com/apache/incubator-superset/pull/7772 ### CATEGORY Choose one - [ ] Bug Fix - [X] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR changes the `FiltertableTable` component to reuse an `svg` component when computing the width of each cell in the table. This leads to improvements of ~10x on large tables (see https://github.com/apache-superset/superset-ui/pull/173)/ <!-- ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF --> <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> Benchmarked with a wide table: 1. Without reusing the svg node: 4315ms 2. Reusing the svg node: 2167ms 3. Reusing the svg node and the textNode (this PR and https://github.com/apache-superset/superset-ui/pull/173): 481ms ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @etr2460
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
