aminghadersohi commented on PR #36033:
URL: https://github.com/apache/superset/pull/36033#issuecomment-3499230852
## Addressed Review Feedback
Thanks for the reviews! I've addressed both issues:
### 1. Fixed Docstring Formatting (Bito Bot feedback)
- Moved summary to same line as opening quotes in
`get_default_instructions()` docstring
- File: `superset/mcp_service/app.py:34`
### 2. Made MCP_SERVICE_BRANDING Actually Used (Korbit AI feedback)
The `MCP_SERVICE_BRANDING` constant was defined but not used. Fixed by:
- Added `branding` parameter to `create_mcp_app()` function
- Added `"branding": MCP_SERVICE_BRANDING` to `MCP_FACTORY_CONFIG`
- Now when factory config is used, branding flows through properly to
generate instructions
**How it works now:**
- `MCP_FACTORY_CONFIG` includes `branding` field
- `create_mcp_app(branding=...)` receives it and generates branded
instructions
- If `branding` is provided but `instructions` is None, calls
`get_default_instructions(branding)`
- If neither provided, falls back to `DEFAULT_INSTRUCTIONS` ("Apache
Superset")
All pre-commit checks passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
