sadpandajoe commented on code in PR #35968:
URL: https://github.com/apache/superset/pull/35968#discussion_r2500758453


##########
superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx:
##########
@@ -467,7 +542,7 @@ describe('plugin-chart-table', () => {
       });
 
       it('render cell without color', () => {
-        const dataWithEmptyCell = testData.advanced.queriesData[0];
+        const dataWithEmptyCell = cloneDeep(testData.advanced.queriesData[0]);

Review Comment:
   The cloned data is used in the test, prevents mutation and things are 
working correctly. I don't thin this is a release blocker unless if the test 
becomes flakey.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to