sadpandajoe commented on code in PR #35969:
URL: https://github.com/apache/superset/pull/35969#discussion_r2501595979
##########
superset/charts/schemas.py:
##########
@@ -1482,9 +1482,12 @@ class ChartDataResponseResult(Schema):
allow_none=None,
)
query = fields.String(
- metadata={"description": "The executed query statement"},
- required=True,
- allow_none=False,
+ metadata={
+ "description": "The executed query statement. May be absent when "
+ "validation errors occur."
+ },
+ required=False,
+ allow_none=True,
)
Review Comment:
The schema is used for multiple result types with different field
requirements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]