Copilot commented on code in PR #36041:
URL: https://github.com/apache/superset/pull/36041#discussion_r2504926296
##########
superset-frontend/webpack.config.js:
##########
@@ -181,6 +182,11 @@ if (!process.env.CI) {
plugins.push(new webpack.ProgressPlugin());
}
+// Add React Refresh plugin for development mode
+if (isDevMode) {
+ plugins.push(new ReactRefreshWebpackPlugin());
+}
Review Comment:
React Refresh is already enabled in the SWC loader configuration at line 255
(`refresh: isDevMode`). Adding the ReactRefreshWebpackPlugin creates a
redundant configuration that may cause conflicts. SWC's built-in React Refresh
support is sufficient and doesn't require the additional webpack plugin.
Consider removing this plugin instantiation or disabling the SWC refresh option
if you specifically need to use the webpack plugin approach.
```suggestion
// React Refresh is handled by SWC; do not add ReactRefreshWebpackPlugin to
avoid conflicts.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
