sadpandajoe commented on code in PR #35938:
URL: https://github.com/apache/superset/pull/35938#discussion_r2505196444
##########
.github/workflows/bashlib.sh:
##########
@@ -238,8 +239,26 @@ playwright-run() {
say "::group::Run Playwright tests"
echo "Running Playwright with baseURL: ${PLAYWRIGHT_BASE_URL}"
- npx playwright test auth/login --reporter=github --output=playwright-results
- local status=$?
+ if [ -n "$TEST_PATH" ]; then
Review Comment:
Thanks for the suggestion! The current approach intentionally handles both
non-existent directories and empty directories the same way - by skipping the
test run gracefully.
The `2>/dev/null` suppresses errors from `find` when the directory doesn't
exist, and the message "No test files found in ${TEST_PATH}" is accurate for
both scenarios (missing directory = no test files, empty directory = no test
files).
Adding an explicit directory check would provide a slightly more specific
error message, but for this use case, the distinction doesn't add value since
we want to skip tests in both situations. The current implementation is simpler
and accomplishes the goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
