aminghadersohi commented on PR #36035: URL: https://github.com/apache/superset/pull/36035#issuecomment-3505610394
## Addressed Copilot Review Feedback Removed the unused `filter_model_fields()` utility function as noted by @copilot-pull-request-reviewer. **Changes in commit ba0be2b:** - Deleted unused `filter_model_fields()` function and its imports - Kept `_is_uuid()` function which is still used by `mcp_core.py` - Reduced file from 147 lines to 30 lines **Context:** The `filter_model_fields()` utility was initially created to address Korbit AI's review feedback about field filtering. However, the implementation was refactored to use Pydantic's `@model_serializer` decorator approach instead, which is cleaner and more idiomatic. The current implementation uses: - `@model_serializer` decorators in schema files - Serialization context passed to tools - Direct `dict[str, Any]` returns from list tools This approach is better because it: - Uses Pydantic's built-in serialization features - Avoids dynamic model creation - Cleaner separation of concerns All tests still passing! ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
