kgabryje opened a new pull request, #36051: URL: https://github.com/apache/superset/pull/36051
### SUMMARY Supplement of https://github.com/apache/superset/pull/36027 Simplify the logic around taking tile screenshots with playwright. This PR removes scrolling and calculations based on `getBoundingClientRect`. Instead, we take tile screenshots by simply calculating the (x,y) coordinates of the clip window based on tile index and viewport height. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS Unit tests should pass. For manual testing, create a large dashboard (longer than `SCREENSHOT_TILED_HEIGHT_THRESHOLD` from config.py) and run a report. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
