etr2460 commented on a change in pull request #7772: Reuse SVG node
URL:
https://github.com/apache/incubator-superset/pull/7772#discussion_r297295858
##########
File path: superset/assets/src/components/FilterableTable/FilterableTable.jsx
##########
@@ -29,16 +29,18 @@ import {
SortIndicator,
Table,
} from 'react-virtualized';
-import { getTextDimension } from '@superset-ui/dimension';
+import { createSVGNode, getTextDimension } from '@superset-ui/dimension';
import { t } from '@superset-ui/translation';
import Button from '../Button';
import CopyToClipboard from '../CopyToClipboard';
import ModalTrigger from '../ModalTrigger';
import TooltipWrapper from '../TooltipWrapper';
+const svg = createSVGNode({ container: document.body });
Review comment:
does this ever get removed from the DOM? Maybe it would be better to create
the node in the ` getWidthsForColumns` function and remove it from the DOM
after everything is measured
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
