[GitHub] [incubator-superset] betodealmeida opened a new pull request #7777: Truncate data that is expanded

[GitBox]

betodealmeida opened a new pull request #7777: Truncate data that is expanded
URL: https://github.com/apache/incubator-superset/pull/7777
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   When we expand complex columns in SQL Lab, the original data is still 
presented. This is redundant, and for most rows the values will be partially 
truncated. Users have complained that this wastes valuable space when 
previewing wide tables, while at the same bringing very little information.
   
   This PR modifies the results table so that complex columns are presented 
with `[...]` or `{...}` as the results, instead of the full values (which can 
be seen in the columns to its left). See the screenshots below:
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   Before:
   
   <img width="852" alt="Screen Shot 2019-06-25 at 11 27 08 AM" 
src="https://user-images.githubusercontent.com/1534870/60123416-47cd9c80-973c-11e9-83e8-0ffb7f1a02aa.png";>
   
   After:
   
   <img width="509" alt="Screen Shot 2019-06-25 at 11 27 33 AM" 
src="https://user-images.githubusercontent.com/1534870/60123424-4b612380-973c-11e9-8186-7f8d3af6740c.png";>
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [X] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @khtruong @etr2460 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org