betodealmeida commented on code in PR #34091:
URL: https://github.com/apache/superset/pull/34091#discussion_r2519780091
##########
superset/db_engine_specs/base.py:
##########
@@ -1907,9 +1909,14 @@ def make_label_compatible(cls, label: str) -> str |
quoted_name:
generate a truncated label by calling truncate_label().
:param label: expected expression label/alias
+ :param database: optional Database instance for db-specific label
mutation logic
:return: conditionally mutated label supported by the db engine
"""
- label_mutated = cls._mutate_label(label)
+ if "database" in signature(cls._mutate_label).parameters:
+ label_mutated = cls._mutate_label(label, database=database)
+ else:
+ label_mutated = cls._mutate_label(label)
Review Comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
