betodealmeida commented on issue #7748: [SIP-23] Move SQL Lab storage out of 
browser localStorage
URL: 
https://github.com/apache/incubator-superset/issues/7748#issuecomment-505651336
 
 
   @etr2460 
   
   > What happens if someone has the same SQL Lab tab in two different 
browsers? Do we provide a cursor for updating the tabs/queries, or do we just 
let people overwrite it automatically? How do we sync the state of the backend 
to the frontend?
   
   I'm not sure what's the best way of handling this. Currently the last edit 
is persisted, but not propagated to other open tabs. The implementation 
proposed would preserve that behavior.
   
   We could use `localStorage` to store if a given tab is being edited, so that 
when the user opens the same tab in a new browser tab they get a message 
warning them, or the tab textarea is rendered as read-only, with option to 
takeover. Any thoughts?
   
   > Can the bootstrap payload include the tab details for the active tab too? 
That would improve load time I think
   
   Good point.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to