alex241728 commented on PR #35915:
URL: https://github.com/apache/superset/pull/35915#issuecomment-3528286728
> > Looking at some of the failing CI stuff, this PR _might_ need a rebase,
pulling in the latest changes from `master` to resolve a couple of the items
(at least I hope it will fix the typescript issue I'm currently seeing).
>
> @rusackas I have solved the suggestions provided by copilot. However,
there is one thing I cannot solve in the pre-commit checks, which is provided
in the quote. By the way, the transformProps.test for bar chart contains the
same superTheme from the same file. It has the type error too.
>
> > Type checking 3 changed TypeScript files...
> > Running targeted type check on 3 files...
> >
plugins/plugin-chart-echarts/test/Timeseries/Bar/transformProps.test.ts:20:31 -
error TS6305: Output file
'/Users/alex241728/superset/superset-frontend/packages/superset-core/lib/ui/index.d.ts'
has not been built from source file
'/Users/alex241728/superset/superset-frontend/packages/superset-core/src/ui/index.ts'.
> > 20 import { supersetTheme } from '@apache-superset/core/ui';
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
plugins/plugin-chart-echarts/test/Timeseries/Scatter/transformProps.test.ts:33:31
- error TS6305: Output file
'/Users/alex241728/superset/superset-frontend/packages/superset-core/lib/ui/index.d.ts'
has not been built from source file
'/Users/alex241728/superset/superset-frontend/packages/superset-core/src/ui/index.ts'.
> > 33 import { supersetTheme } from '@apache-superset/core/ui';
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~
> > Found 2 errors in 2 files.
> > Errors Files
> > 1
plugins/plugin-chart-echarts/test/Timeseries/Bar/transformProps.test.ts:20
> > 1
plugins/plugin-chart-echarts/test/Timeseries/Scatter/transformProps.test.ts:33
> > Failed to execute type checking: Type check failed with exit code 2
The error is fixed by
>cd superset-frontend
>npm run plugins:build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
