msyavuz commented on code in PR #35986:
URL: https://github.com/apache/superset/pull/35986#discussion_r2523984232
##########
superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx:
##########
@@ -207,6 +208,68 @@ export function AsyncAceEditor(
}
}, [keywords, setCompleters]);
+ // Move autocomplete popup to the nearest parent container with
data-ace-container
+ useEffect(() => {
+ const editorInstance = (ref as React.RefObject<AceEditor>)?.current
+ ?.editor;
+ if (!editorInstance) return;
+
+ const editorContainer = editorInstance.container;
+ if (!editorContainer) return;
+
+ // Cache DOM elements to avoid repeated queries on every command
execution
+ let cachedAutocompletePopup: HTMLElement | null = null;
+ let cachedTargetContainer: Element | null = null;
+
+ const moveAutocompleteToContainer = () => {
+ // Revalidate cached popup if missing or detached from DOM
+ if (
+ !cachedAutocompletePopup ||
+ !document.body.contains(cachedAutocompletePopup)
+ ) {
+ cachedAutocompletePopup =
+ editorContainer.querySelector<HTMLElement>(
+ '.ace_autocomplete',
+ ) ?? document.querySelector<HTMLElement>('.ace_autocomplete');
+ }
+
+ // Revalidate cached container if missing or detached
+ if (
+ !cachedTargetContainer ||
+ !document.body.contains(cachedTargetContainer)
+ ) {
+ cachedTargetContainer =
+ editorContainer.closest('#ace-editor') ??
+ editorContainer.parentElement;
+ }
+
+ if (
+ cachedAutocompletePopup &&
+ cachedTargetContainer &&
+ cachedTargetContainer !== document.body
+ ) {
+ cachedTargetContainer.appendChild(cachedAutocompletePopup);
+ cachedAutocompletePopup.dataset.aceAutocomplete = 'true';
+ }
+ };
+
+ const handleAfterExec = (e: Ace.Operation) => {
+ const name = e?.command?.name;
+ if (name === 'insertstring' || name === 'startAutocomplete') {
Review Comment:
Is there a type for this?
##########
docker/pythonpath_dev/superset_config_docker_light.py:
##########
@@ -19,6 +19,7 @@
# Import all settings from the main config first
from flask_caching.backends.filesystemcache import FileSystemCache
+
Review Comment:
```suggestion
```
##########
superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx:
##########
@@ -288,14 +351,24 @@ export function AsyncAceEditor(
border: 1px solid ${token.colorBorderSecondary};
box-shadow: ${token.boxShadow};
border-radius: ${token.borderRadius}px;
+ padding: ${token.paddingXS}px ${token.paddingXS}px;
+ }
+
+ .ace_tooltip.ace_doc-tooltip {
+ display: flex !important;
Review Comment:
Is this `important` necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
