msyavuz commented on code in PR #36087:
URL: https://github.com/apache/superset/pull/36087#discussion_r2523942707
##########
superset-frontend/src/features/databases/DatabaseModal/SqlAlchemyForm.tsx:
##########
@@ -97,15 +97,17 @@ const SqlAlchemyTab = ({
</div>
</StyledInputContainer>
{children}
- <Button
- onClick={testConnection}
- loading={testInProgress}
- cta
- buttonStyle="link"
- css={(theme: SupersetTheme) => wideButton(theme)}
- >
- {t('Test connection')}
- </Button>
+ <div css={(theme: SupersetTheme) => marginBottom(theme)}>
+ <Button
+ onClick={testConnection}
+ loading={testInProgress}
+ cta
+ buttonStyle="link"
+ css={(theme: SupersetTheme) => wideButton(theme)}
+ >
+ {t('Test connection')}
+ </Button>
+ </div>
Review Comment:
Can we add the style to button component instead of creating a wrapper just
for styling?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
