rusackas commented on PR #35259: URL: https://github.com/apache/superset/pull/35259#issuecomment-3529513369
This is quite the thread! Here's a Claude generated recap, if it helps anyone take stock of things: ## Remaining Blockers for PR #35259 Based on the discussion thread and current diff, here's a summary of items that need resolution before this PR can move forward: Committers can edit this comment and replace `[ ]` with `[X]` to track decisions. | Item | To Do | Hold Off | Done | |------|-------|----------|------| | **Remove FAB dependency**: Replace `BaseFilter` with a more generic filtering approach to avoid Flask-AppBuilder coupling in superset-core | [ ] | [ ] | [ ] | | **Type improvements**: Change `list` to `Collection` in method signatures where order doesn't matter | [ ] | [ ] | [ ] | | **UUID migration**: Decide whether to migrate to UUID-only identifiers now (breaking change) or support mixed int/str/UUID | [ ] | [ ] | [ ] | | **UUID-only for public API**: Expose only UUID-based lookups in public API, keep int/str lookups private (@villebro's proposal) | [ ] | [ ] | [ ] | | **Composite key support**: Consider future support for composite primary keys in DAO methods | [ ] | [ ] | [ ] | | **Error handling**: Decide between returning `Optional[T]` vs raising exceptions (implement both `get()` and `get_or_none()` patterns?) | [ ] | [ ] | [ ] | | **Naming convention**: Standardize abstract class names (e.g., `Database` vs `AbstractDatabase` vs `BaseDatabase`) | [ ] | [ ] | [ ] | | **Commands scope**: Determine which commands belong in superset-core vs treating most as private/app-specific | [ ] | [ ] | [ ] | | **API exposure strategy**: Decide if superset-core should be 100% private with a separate superset-api package for public APIs | [ ] | [ ] | [ ] | | **Private underscore convention**: Consider using `_` prefix convention for private modules/functions in superset-core | [ ] | [ ] | [ ] | | **Security filtering approach**: Resolve @dpgaspar's concern about maintaining static base filters for security | [ ] | [ ] | [ ] | | **Fix bycatch issues**: Address the two type issues found in security manager (`database.database_name` and `datasource_.perm or ""`) | [ ] | [ ] | [ ] | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
