mistercrunch commented on issue #7770: Autocomplete in the table browser in SQL lab is broken - Fix part 2 URL: https://github.com/apache/incubator-superset/pull/7770#issuecomment-505730524 Another element of complexity that I was dealing with when I generalized that component (for `<TableEditor />`) is the [optional, see `this.props.database.allow_multi_schema_metadata_fetch`] feature where if the `schema` isn't selected you can in theory search (as in autocomplete) across all tables across all schemas. This feature makes the code opaque and depends on eager caching techniques in the backend (I think at Airbnb there's a cron refreshing that cache from the catalog every 5). Clearly searching/ across schemas is super useful, but adds another layer of complexity on top or an already heavy component.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
