sadpandajoe commented on code in PR #35810:
URL: https://github.com/apache/superset/pull/35810#discussion_r2525948410
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/components/DatasetUsageTab/index.tsx:
##########
@@ -112,23 +113,38 @@ const DatasetUsageTab = ({
async (page = 1, column = sortColumn, direction = sortDirection) => {
if (!datasourceId) return;
- setLoading(true);
+ if (isMountedRef.current) {
+ setLoading(true);
+ }
Review Comment:
Removing the mount guard from setLoading(true) would reintroduce the exact
bug this PR fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
