amaannawab923 commented on code in PR #36136:
URL: https://github.com/apache/superset/pull/36136#discussion_r2533767495
##########
superset/common/query_object.py:
##########
@@ -336,6 +336,13 @@ def _is_valid_date_range(self, date_range: str) -> bool:
def _sanitize_filters(self) -> None:
from superset.jinja_context import get_template_processor
+ from superset.utils.sql_sanitizer import (
+ is_ag_grid_viz_type,
+ sanitize_sql_with_sqlglot,
+ )
+
+ viz_type = self.extras.get("viz_type")
+ use_sqlglot_escaping = is_ag_grid_viz_type(viz_type)
Review Comment:
Nope , shouldnt be a negative effect, Just did it in case if any issue
arises and we can remove viz type check in a follow up pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
