Rattlyy commented on issue #36132: URL: https://github.com/apache/superset/issues/36132#issuecomment-3545957961
> [@sadpandajoe](https://github.com/sadpandajoe) [@Rattlyy](https://github.com/Rattlyy) correct me if I'm wrong but based on this: > > > also tried 4.0.0 where the PR wasn't merged yet and the anchor element with tab id was still there but still same behaviour was there. > > It seems you tested before my PR was merged and the issue was already happening, so I don't think my PR introduced this issue. I remember when the SDK was initially released there used to be an `activeTab` property that I never managed to make it work, so I'm wondering if this is broken since then. With your PR anchor links are gone entirely, totally breaking them. (https://github.com/apache/superset/blob/b5cac47ba7ebde5e1fe08e5fb1c503bf4eebc3a9/superset-frontend/src/dashboard/components/gridComponents/Header/Header.jsx#L251 - the !embeddedMode part) Without your PR (4.0.0) anchor links work, but only if you append #<tabid> to the URL with the permalink_key (https://github.com/apache/superset/blob/b5cac47ba7ebde5e1fe08e5fb1c503bf4eebc3a9/superset-frontend/src/dashboard/components/AnchorLink/index.tsx#L54) @Vitor-Avila -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
