villebro commented on code in PR #36151: URL: https://github.com/apache/superset/pull/36151#discussion_r2540084064
########## superset/mcp_service/CLAUDE.md: ########## @@ -289,8 +296,7 @@ def my_function( **Key rules:** - Use `T | None` instead of `Optional[T]` -- Do NOT import `Optional` from typing -- Still import `List`, `Dict`, `Any`, etc. from typing (for now) +- Do NOT import `Optional`, `List`, `Dict` from typing, prefer `| None`, `list[]` etc Review Comment: Bycatch, I think we've moved from `List[]` to `list[]` some time ago. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
