LuisSanchez opened a new pull request, #36209: URL: https://github.com/apache/superset/pull/36209
### SUMMARY Disable 1password suggestions on search filters according to the issue [here](https://app.shortcut.com/preset-ext/story/93996/settings-some-filter-fields-in-settings-pages-are-recognized-by-onepassword-as-login-fields). This is a known issue of 1password reported [here](https://developer.1password.com/docs/web/compatible-website-design/), so we must apply the attrs on the input so the 1pass can ignore the suggestion. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF #### Before: It happens in all modules where there is a search input, for example: <img width="2894" height="1514" alt="image" src="https://github.com/user-attachments/assets/96793e31-1223-4b62-a010-21ed1832e526"; /> #### After: <img width="1347" height="837" alt="image" src="https://github.com/user-attachments/assets/66fd5f7c-cb35-4552-93ee-7994a5d3743d"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Login. 2. Enter user settings that has a search input box, for example **Annotations Layers**. 3. Try typing on the search box, the 1password icon **must not** appear. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: [here](https://app.shortcut.com/preset-ext/story/93996/settings-some-filter-fields-in-settings-pages-are-recognized-by-onepassword-as-login-fields) - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
