sfirke commented on PR #36128: URL: https://github.com/apache/superset/pull/36128#issuecomment-3558749211
Hello @YousufFFFF - this PR seems to modify or rename a bunch of files unrelated to the fix. Please undo that. It also is not passing CI checks, please ensure all CI checks and tests pass before requesting review. Since you mention being new to open source I want to include some relevant context. The number one limiting factor for the Superset project is reviewer capacity. Even before AI code generation that was the case; now it's absolutely a bottleneck. We can generate all the code in the world but skilled time to review and give feedback or merge is precious. So to be helpful to the projects, it's imperative that PR authors have: 1. Gotten all tests passing 2. Considered and responded to any automated code-review feedback (I see some above in this PR) 3. Fully understand all aspects of their code Unfortunately cases where all of the above are not met can end up hurting the project. If/when all of those three are in place, feel free to request review. Try to get tests passing locally but if you need me to trigger CI runs on GitHub you can ping me and I'll do that. Per my third bullet above, I keep my own contributions to Superset limited (documentation, small fixes) because while I can have AI generate code, when it's complex or wide-ranging I typically don't feel confident enough that I understand it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
