sadpandajoe commented on code in PR #36057:
URL: https://github.com/apache/superset/pull/36057#discussion_r2550846207
##########
superset/models/helpers.py:
##########
@@ -1146,6 +1183,10 @@ def assign_column_label(df: pd.DataFrame) ->
Optional[pd.DataFrame]:
mutator=assign_column_label,
)
except Exception as ex: # pylint: disable=broad-except
+ # Re-raise SupersetErrorException (includes OAuth2RedirectError)
+ # to bubble up to API layer
+ if isinstance(ex, SupersetErrorException):
+ raise
Review Comment:
The new `ExploreMixin.query` only re-raises `SupersetErrorException`, so
could `SupersetErrorsException` get swallowed and converted to a generic failed
`QueryResult`? Would this then lose multi-error details/status for the error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
