betodealmeida opened a new pull request, #36226: URL: https://github.com/apache/superset/pull/36226
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR fixes duplicate `contribution_totals` calculation causing cache key mismatches and 422 errors in async query execution by skipping `ensure_totals_available()` when fetching cached results. #### Root Cause In async mode, queries execute twice: 1. Worker: Executes query → calculates contribution_totals → caches result 2. Cache fetch: Fetches from cache → recalculates contribution_totals → different value → cache key mismatch → 422 error The contribution_totals values differ due to: - Pinot data updating frequently between requests - Floating-point precision differences - Different data samples (row limit vs all records) Since `contribution_totals` was included in cache keys (from `post_processing`), every request generated a different cache key, preventing cache hits. The solution is to skip `ensure_totals_available()` when `force_cached=True` to prevent recalculating `contribution_totals` from cached results: ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
