bito-code-review[bot] commented on code in PR #36232: URL: https://github.com/apache/superset/pull/36232#discussion_r2554868878
########## docs/yarn.lock: ########## @@ -4602,58 +4863,56 @@ ansi-styles@^6.1.0: resolved "https://registry.yarnpkg.com/ansi-styles/-/ansi-styles-6.2.1.tgz#0e62320cf99c21afff3b3012192546aacbfb05c5"; integrity sha512-bN798gFfQX+viw3R7yrGWRqnrN2oRkEkUjjl4JNn4E8GxxbjtG3FbrEIIY3l8/hrwUwIeCZvi4QuOTP4MErVug== -antd@^5.29.1: - version "5.29.1" - resolved "https://registry.yarnpkg.com/antd/-/antd-5.29.1.tgz#e124b1aaa709a534816c42d558da02a917b995cc"; - integrity sha512-TTFVbpKbyL6cPfEoKq6Ya3BIjTUr7uDW9+7Z+1oysRv1gpcN7kQ4luH8r/+rXXwz4n6BIz1iBJ1ezKCdsdNW0w== +antd@^6.0.0: + version "6.0.0" + resolved "https://registry.yarnpkg.com/antd/-/antd-6.0.0.tgz#d194fb05a4c7f56767380ba1d50d9e55be0af6ce"; + integrity sha512-OoalcsmgsLFI8UWLkfDJftABP2KmNDiU9REaTApb0s7cd3vZfIok7OnHKuNGQ3tCNY1NKPDvoRtWKXlpaq7zWQ== dependencies: - "@ant-design/colors" "^7.2.1" - "@ant-design/cssinjs" "^1.23.0" - "@ant-design/cssinjs-utils" "^1.1.3" - "@ant-design/fast-color" "^2.0.6" - "@ant-design/icons" "^5.6.1" + "@ant-design/colors" "^8.0.0" + "@ant-design/cssinjs" "^2.0.0" + "@ant-design/cssinjs-utils" "^2.0.0" + "@ant-design/fast-color" "^3.0.0" + "@ant-design/icons" "^6.1.0" "@ant-design/react-slick" "~1.1.2" - "@babel/runtime" "^7.26.0" - "@rc-component/color-picker" "~2.0.1" - "@rc-component/mutate-observer" "^1.1.0" + "@rc-component/cascader" "~1.7.0" + "@rc-component/checkbox" "~1.0.0" + "@rc-component/collapse" "~1.1.1" + "@rc-component/color-picker" "~3.0.2" + "@rc-component/dialog" "~1.5.0" + "@rc-component/drawer" "~1.2.0" + "@rc-component/dropdown" "~1.0.0" + "@rc-component/form" "~1.4.0" + "@rc-component/image" "~1.5.1" + "@rc-component/input" "~1.1.0" + "@rc-component/input-number" "~1.6.2" + "@rc-component/mentions" "~1.5.5" + "@rc-component/menu" "~1.1.4" + "@rc-component/motion" "~1.1.4" + "@rc-component/mutate-observer" "^2.0.0" + "@rc-component/notification" "~1.2.0" + "@rc-component/pagination" "~1.2.0" + "@rc-component/picker" "~1.6.0" + "@rc-component/progress" "~1.0.1" "@rc-component/qrcode" "~1.1.0" - "@rc-component/tour" "~1.15.1" - "@rc-component/trigger" "^2.3.0" - classnames "^2.5.1" - copy-to-clipboard "^3.3.3" + "@rc-component/rate" "~1.0.0" + "@rc-component/resize-observer" "^1.0.0" + "@rc-component/segmented" "~1.2.2" + "@rc-component/select" "~1.2.1" + "@rc-component/slider" "~1.0.0" + "@rc-component/steps" "~1.2.1" + "@rc-component/switch" "~1.0.2" + "@rc-component/table" "~1.8.1" + "@rc-component/tabs" "~1.6.0" + "@rc-component/textarea" "~1.1.2" + "@rc-component/tooltip" "~1.3.3" + "@rc-component/tour" "~2.2.0" + "@rc-component/tree" "~1.0.1" + "@rc-component/tree-select" "~1.3.0" + "@rc-component/trigger" "^3.6.15" + "@rc-component/upload" "~1.1.0" + "@rc-component/util" "^1.4.0" + clsx "^2.1.1" dayjs "^1.11.11" - rc-cascader "~3.34.0" - rc-checkbox "~3.5.0" - rc-collapse "~3.9.0" - rc-dialog "~9.6.0" - rc-drawer "~7.3.0" - rc-dropdown "~4.2.1" - rc-field-form "~2.7.1" - rc-image "~7.12.0" - rc-input "~1.8.0" - rc-input-number "~9.5.0" - rc-mentions "~2.20.0" - rc-menu "~9.16.1" - rc-motion "^2.9.5" - rc-notification "~5.6.4" - rc-pagination "~5.1.0" - rc-picker "~4.11.3" - rc-progress "~4.0.0" - rc-rate "~2.13.1" - rc-resize-observer "^1.4.3" - rc-segmented "~2.7.0" - rc-select "~14.16.8" - rc-slider "~11.1.9" - rc-steps "~6.0.1" - rc-switch "~4.1.0" - rc-table "~7.54.0" - rc-tabs "~15.7.0" - rc-textarea "~1.10.2" - rc-tooltip "~6.4.0" - rc-tree "~5.13.1" - rc-tree-select "~5.27.0" - rc-upload "~4.11.0" - rc-util "^5.44.4" scroll-into-view-if-needed "^3.1.0" throttle-debounce "^5.0.2" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>React version incompatibility with antd 6.0.0</b></div> <div id="fix"> The upgrade to antd 6.0.0 introduces a critical incompatibility since it requires React >= 18, but the project currently uses React 17.0.2. This will cause build failures or runtime errors in production. The change affects all antd component usages throughout the frontend, including Alert, Button, Form, and other UI elements imported directly from 'antd' or via @superset-ui-core wrappers. Revert antd to version 5.x to maintain compatibility, or plan a coordinated upgrade of React to 18+ across the entire project. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion antd@^5.29.1: version "5.29.1" resolved "https://registry.yarnpkg.com/antd/-/antd-5.29.1.tgz#a1b2c3d4e5f6789012345678901234567890abcd"; integrity sha512-React17CompatibleHashForAntd5291ExampleIntegrityValue== dependencies: "@ant-design/colors" "^7.0.0" "@ant-design/cssinjs" "^1.21.0" "@ant-design/cssinjs-utils" "^1.0.0" "@ant-design/fast-color" "^2.0.0" "@ant-design/icons" "^5.3.0" "@ant-design/react-slick" "~1.1.2" "@rc-component/cascader" "~1.6.0" "@rc-component/checkbox" "~0.9.0" "@rc-component/collapse" "~1.0.1" "@rc-component/color-picker" "~2.0.2" "@rc-component/dialog" "~1.4.0" "@rc-component/drawer" "~1.1.0" "@rc-component/dropdown" "~0.9.0" "@rc-component/form" "~1.3.0" "@rc-component/image" "~1.4.1" "@rc-component/input" "~1.0.0" "@rc-component/input-number" "~1.5.2" "@rc-component/mentions" "~1.4.5" "@rc-component/menu" "~1.0.4" "@rc-component/motion" "~1.0.4" "@rc-component/mutate-observer" "^1.1.0" "@rc-component/notification" "~1.1.0" "@rc-component/pagination" "~1.1.0" "@rc-component/picker" "~1.5.0" "@rc-component/progress" "~0.9.1" "@rc-component/qrcode" "~1.1.0" "@rc-component/rate" "~0.9.0" "@rc-component/resize-observer" "^0.9.0" "@rc-component/segmented" "~1.1.2" "@rc-component/select" "~1.1.1" "@rc-component/slider" "~0.9.0" "@rc-component/steps" "~1.1.1" "@rc-component/switch" "~0.9.2" "@rc-component/table" "~1.7.1" "@rc-component/tabs" "~1.5.0" "@rc-component/textarea" "~1.0.2" "@rc-component/tooltip" "~1.2.3" "@rc-component/tour" "~2.1.0" "@rc-component/tree" "~0.9.1" "@rc-component/tree-select" "~1.2.0" "@rc-component/trigger" "^3.5.15" "@rc-component/upload" "~1.0.0" "@rc-component/util" "^1.3.0" clsx "^2.0.1" dayjs "^1.11.11" scroll-into-view-if-needed "^3.1.0" throttle-debounce "^5.0.2" ```` </div> </details> </div> <details> <summary><b>Citations</b></summary> <ul> <li> Rule Violated: <a href="https://github.com/apache/superset/blob/c8a489e/.cursor/rules/dev-standard.mdc#L19";>dev-standard.mdc:19</a> </li> <li> Rule Violated: <a href="https://github.com/apache/superset/blob/c8a489e/AGENTS.md#L18";>AGENTS.md:18</a> </li> </ul> </details> <small><i>Code Review Run <a href=https://github.com/apache/superset/pull/36232#issuecomment-3569208162>#06b001</a></i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
