Antonio-RiveroMartnez opened a new pull request, #36246: URL: https://github.com/apache/superset/pull/36246
### SUMMARY Noticed our Dashboard List API is returning ALL the implicit tags in the List endpoint, which is damaging the performance of such API. These tags are pure metadata, and not used for any security process in our app, what's more, even the UI is filtering those and only rendering `custom` ones. This PR introduces a new config that by default respect the current behavior so nothing gets changed inadvertently, this new config will make FAB filter at the JOIN level which tags to include as part of the response. This new cofig is read by a new Mixin added to the `DashboardRestApi`. Why at the JOIN level? Because filtering at python level with for example a callable would not help on query performance, only on response size. Why a config and not a Feature Flag? Manipulating the model is not something you can do at runtime (request), so that's why I'm using a config. Why a Mixin? We could consider reusing this mixin on other parts where tags are returned by default like `ChartRestApi` etc later on. At some point we would like to evaluate how to get rid of those implicit tag altogether in these APIs, but that major effort would be out of the scope of this initial optimization. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Default behavior without filtering: <img width="1543" height="710" alt="before" src="https://github.com/user-attachments/assets/0847bd24-2cd0-4aa6-a1f8-fc9be13dd10f"; /> When the config is enabled: <img width="1479" height="712" alt="now" src="https://github.com/user-attachments/assets/ad329ab2-9a40-46e5-aeba-ea5877ac42b3"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
